diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2022-02-18 09:38:14 -0500 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2022-03-14 13:13:53 +0100 |
| commit | 9f5710bbfd3031dd7ce244fa26fba896d35f5342 (patch) | |
| tree | 2836476e968e4d92f8f45aa59ceafa57d2049721 /fs/ioctl.c | |
| parent | ae460f058e9ff31946cc393bf897fc44483f0876 (diff) | |
| download | linux-9f5710bbfd3031dd7ce244fa26fba896d35f5342.tar.gz linux-9f5710bbfd3031dd7ce244fa26fba896d35f5342.tar.bz2 linux-9f5710bbfd3031dd7ce244fa26fba896d35f5342.zip | |
fs: allow cross-vfsmount reflink/dedupe
Currently we disallow reflink and dedupe if the two files aren't on the
same vfsmount. However we really only need to disallow it if they're
not on the same super block. It is very common for btrfs to have a main
subvolume that is mounted and then different subvolumes mounted at
different locations. It's allowed to reflink between these volumes, but
the vfsmount check disallows this. Instead fix dedupe to check for the
same superblock, and simply remove the vfsmount check for reflink as it
already does the superblock check.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/ioctl.c')
| -rw-r--r-- | fs/ioctl.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/ioctl.c b/fs/ioctl.c index 1ed097e94af2..090bf47606ab 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -236,9 +236,6 @@ static long ioctl_file_clone(struct file *dst_file, unsigned long srcfd, if (!src_file.file) return -EBADF; - ret = -EXDEV; - if (src_file.file->f_path.mnt != dst_file->f_path.mnt) - goto fdput; cloned = vfs_clone_file_range(src_file.file, off, dst_file, destoff, olen, 0); if (cloned < 0) @@ -247,7 +244,6 @@ static long ioctl_file_clone(struct file *dst_file, unsigned long srcfd, ret = -EINVAL; else ret = 0; -fdput: fdput(src_file); return ret; } |