diff options
| author | Daniel Martín Gómez <dalme@riseup.net> | 2024-11-07 15:45:38 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-11-13 12:56:48 -0500 |
| commit | 3e7c69cdb053f9edea95502853f35952ab6cbf06 (patch) | |
| tree | 8d498c002c9f57b2fe33872d30a669549fe3e2a3 /fs/jbd2 | |
| parent | e06a8c24f6445c2f1b5255caa4f63b38e31c43fa (diff) | |
| download | linux-3e7c69cdb053f9edea95502853f35952ab6cbf06.tar.gz linux-3e7c69cdb053f9edea95502853f35952ab6cbf06.tar.bz2 linux-3e7c69cdb053f9edea95502853f35952ab6cbf06.zip | |
jbd2: Fix comment describing journal_init_common()
The code indicates that journal_init_common() fills the journal_t object
it returns while the comment incorrectly states that only a few fields are
initialised. Also, the comment claims that journal structures could be
created from scratch which isn't possible as journal_init_common() calls
journal_load_superblock() which loads and checks journal superblock from
disk.
Signed-off-by: Daniel Martín Gómez <dalme@riseup.net>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20241107144538.3544-1-dalme@riseup.net
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/jbd2')
| -rw-r--r-- | fs/jbd2/journal.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 29d30eddf727..7e49d912b091 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1512,9 +1512,10 @@ static int journal_load_superblock(journal_t *journal) * destroy journal_t structures, and to initialise and read existing * journal blocks from disk. */ -/* First: create and setup a journal_t object in memory. We initialise - * very few fields yet: that has to wait until we have created the - * journal structures from from scratch, or loaded them from disk. */ +/* The journal_init_common() function creates and fills a journal_t object + * in memory. It calls journal_load_superblock() to load the on-disk journal + * superblock and initialize the journal_t object. + */ static journal_t *journal_init_common(struct block_device *bdev, struct block_device *fs_dev, |