summaryrefslogtreecommitdiffstats
path: root/fs/kernfs
diff options
context:
space:
mode:
authorMuchun Song <songmuchun@bytedance.com>2023-05-23 10:40:17 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-05-31 19:03:49 +0100
commit30480b988f88c279752f3202a26b6fee5f586aef (patch)
treefda750c9a4a86d34cfd2f3da57b2fddba9dd2f68 /fs/kernfs
parent6bea9ea6bb21ccee2aad0aa2a845499e0aa2f7f9 (diff)
downloadlinux-30480b988f88c279752f3202a26b6fee5f586aef.tar.gz
linux-30480b988f88c279752f3202a26b6fee5f586aef.tar.bz2
linux-30480b988f88c279752f3202a26b6fee5f586aef.zip
kernfs: fix missing kernfs_idr_lock to remove an ID from the IDR
The root->ino_idr is supposed to be protected by kernfs_idr_lock, fix it. Fixes: 488dee96bb62 ("kernfs: allow creating kernfs objects with arbitrary uid/gid") Signed-off-by: Muchun Song <songmuchun@bytedance.com> Acked-by: Tejun Heo <tj@kernel.org> Link: https://lore.kernel.org/r/20230523024017.24851-1-songmuchun@bytedance.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/kernfs')
-rw-r--r--fs/kernfs/dir.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 45b6919903e6..5a1a4af9d3d2 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -655,7 +655,9 @@ static struct kernfs_node *__kernfs_new_node(struct kernfs_root *root,
return kn;
err_out3:
+ spin_lock(&kernfs_idr_lock);
idr_remove(&root->ino_idr, (u32)kernfs_ino(kn));
+ spin_unlock(&kernfs_idr_lock);
err_out2:
kmem_cache_free(kernfs_node_cache, kn);
err_out1: