summaryrefslogtreecommitdiffstats
path: root/fs/ksmbd
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2022-01-15 14:49:00 +0300
committerSteve French <stfrench@microsoft.com>2022-01-18 16:53:14 -0600
commitb207602fb04537cb21ac38fabd7577eca2fa05ae (patch)
treeb41d205f4ca1dbb23fa120f54c16ece0ec449cab /fs/ksmbd
parent2fd5dcb1c8ef96c9f0fa8bda53ca480524b80ae7 (diff)
downloadlinux-b207602fb04537cb21ac38fabd7577eca2fa05ae.tar.gz
linux-b207602fb04537cb21ac38fabd7577eca2fa05ae.tar.bz2
linux-b207602fb04537cb21ac38fabd7577eca2fa05ae.zip
ksmbd: uninitialized variable in create_socket()
The "ksmbd_socket" variable is not initialized on this error path. Cc: stable@vger.kernel.org Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/ksmbd')
-rw-r--r--fs/ksmbd/transport_tcp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
index c14320e03b69..82a1429bbe12 100644
--- a/fs/ksmbd/transport_tcp.c
+++ b/fs/ksmbd/transport_tcp.c
@@ -404,7 +404,7 @@ static int create_socket(struct interface *iface)
&ksmbd_socket);
if (ret) {
pr_err("Can't create socket for ipv4: %d\n", ret);
- goto out_error;
+ goto out_clear;
}
sin.sin_family = PF_INET;
@@ -462,6 +462,7 @@ static int create_socket(struct interface *iface)
out_error:
tcp_destroy_socket(ksmbd_socket);
+out_clear:
iface->ksmbd_socket = NULL;
return ret;
}