diff options
| author | Qinghua Jin <qhjin.dev@gmail.com> | 2022-03-23 16:06:23 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2022-03-23 19:00:34 -0700 |
| commit | 9ce3c0d26c42d279b6c378a03cd6a61d828f19ca (patch) | |
| tree | 9bc4f3477f74077b3a2d0a836c9568646f7a4830 /fs/minix | |
| parent | aeb213cddeb5c31f8d418180e0b9956bfd53b018 (diff) | |
| download | linux-9ce3c0d26c42d279b6c378a03cd6a61d828f19ca.tar.gz linux-9ce3c0d26c42d279b6c378a03cd6a61d828f19ca.tar.bz2 linux-9ce3c0d26c42d279b6c378a03cd6a61d828f19ca.zip | |
minix: fix bug when opening a file with O_DIRECT
Testcase:
1. create a minix file system and mount it
2. open a file on the file system with O_RDWR|O_CREAT|O_TRUNC|O_DIRECT
3. open fails with -EINVAL but leaves an empty file behind. All other
open() failures don't leave the failed open files behind.
It is hard to check the direct_IO op before creating the inode. Just as
ext4 and btrfs do, this patch will resolve the issue by allowing to
create the file with O_DIRECT but returning error when writing the file.
Link: https://lkml.kernel.org/r/20220107133626.413379-1-qhjin.dev@gmail.com
Signed-off-by: Qinghua Jin <qhjin.dev@gmail.com>
Reported-by: Colin Ian King <colin.king@intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/minix')
| -rw-r--r-- | fs/minix/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/minix/inode.c b/fs/minix/inode.c index a71f1cf894b9..d4bd94234ef7 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c @@ -447,7 +447,8 @@ static const struct address_space_operations minix_aops = { .writepage = minix_writepage, .write_begin = minix_write_begin, .write_end = generic_write_end, - .bmap = minix_bmap + .bmap = minix_bmap, + .direct_IO = noop_direct_IO }; static const struct inode_operations minix_symlink_inode_operations = { |