diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2022-01-25 10:17:59 -0500 |
---|---|---|
committer | Chuck Lever <chuck.lever@oracle.com> | 2022-02-28 10:26:39 -0500 |
commit | a9ff2e99e9fa501ec965da03c18a5422b37a2f44 (patch) | |
tree | 0d9598fc3eda25fa163c5ddc07bae3c99e83e98c /fs/nfsd | |
parent | 70a60cbfb613d8f6ffd1d9ade187d0a868066500 (diff) | |
download | linux-a9ff2e99e9fa501ec965da03c18a5422b37a2f44.tar.gz linux-a9ff2e99e9fa501ec965da03c18a5422b37a2f44.tar.bz2 linux-a9ff2e99e9fa501ec965da03c18a5422b37a2f44.zip |
SUNRPC: Remove the .svo_enqueue_xprt method
We have never been able to track down and address the underlying
cause of the performance issues with workqueue-based service
support. svo_enqueue_xprt is called multiple times per RPC, so
it adds instruction path length, but always ends up at the same
function: svc_xprt_do_enqueue(). We do not anticipate needing
this flexibility for dynamic nfsd thread management support.
As a micro-optimization, remove .svo_enqueue_xprt because
Spectre/Meltdown makes virtual function calls more costly.
This change essentially reverts commit b9e13cdfac70 ("nfsd/sunrpc:
turn enqueueing a svc_xprt into a svc_serv operation").
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs/nfsd')
-rw-r--r-- | fs/nfsd/nfssvc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index b8c682b62d29..aeeac6de1f0a 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -615,7 +615,6 @@ static int nfsd_get_default_max_blksize(void) static const struct svc_serv_ops nfsd_thread_sv_ops = { .svo_shutdown = nfsd_last_thread, .svo_function = nfsd, - .svo_enqueue_xprt = svc_xprt_do_enqueue, .svo_module = THIS_MODULE, }; |