diff options
| author | Martin Brandenburg <martin@omnibond.com> | 2018-05-31 16:36:58 +0000 |
|---|---|---|
| committer | Mike Marshall <hubcap@omnibond.com> | 2018-06-01 14:49:46 -0400 |
| commit | f6a4b4c9d07dda90c7c29dae96d6119ac6425dca (patch) | |
| tree | 0e2f6fb341c5cce0f9a6a55f1e16baaacfb7f67d /fs/orangefs | |
| parent | 7f54910fa8dfe504f2e1563f4f6ddc3294dfbf3a (diff) | |
| download | linux-f6a4b4c9d07dda90c7c29dae96d6119ac6425dca.tar.gz linux-f6a4b4c9d07dda90c7c29dae96d6119ac6425dca.tar.bz2 linux-f6a4b4c9d07dda90c7c29dae96d6119ac6425dca.zip | |
orangefs: set i_size on new symlink
As long as a symlink inode remains in-core, the destination (and
therefore size) will not be re-fetched from the server, as it cannot
change. The original implementation of the attribute cache assumed that
setting the expiry time in the past was sufficient to cause a re-fetch
of all attributes on the next getattr. That does not work in this case.
The bug manifested itself as follows. When the command sequence
touch foo; ln -s foo bar; ls -l bar
is run, the output was
lrwxrwxrwx. 1 fedora fedora 4906 Apr 24 19:10 bar -> foo
However, after a re-mount, ls -l bar produces
lrwxrwxrwx. 1 fedora fedora 3 Apr 24 19:10 bar -> foo
After this commit, even before a re-mount, the output is
lrwxrwxrwx. 1 fedora fedora 3 Apr 24 19:10 bar -> foo
Reported-by: Becky Ligon <ligon@clemson.edu>
Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Fixes: 71680c18c8f2 ("orangefs: Cache getattr results.")
Cc: stable@vger.kernel.org
Cc: hubcap@omnibond.com
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Diffstat (limited to 'fs/orangefs')
| -rw-r--r-- | fs/orangefs/namei.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c index 1b5707c44c3f..e026bee02a66 100644 --- a/fs/orangefs/namei.c +++ b/fs/orangefs/namei.c @@ -326,6 +326,13 @@ static int orangefs_symlink(struct inode *dir, ret = PTR_ERR(inode); goto out; } + /* + * This is necessary because orangefs_inode_getattr will not + * re-read symlink size as it is impossible for it to change. + * Invalidating the cache does not help. orangefs_new_inode + * does not set the correct size (it does not know symname). + */ + inode->i_size = strlen(symname); gossip_debug(GOSSIP_NAME_DEBUG, "Assigned symlink inode new number of %pU\n", |