diff options
author | Sergey Senozhatsky <sergey.senozhatsky@gmail.com> | 2018-10-02 11:38:35 +0900 |
---|---|---|
committer | Petr Mladek <pmladek@suse.com> | 2018-10-12 10:03:39 +0200 |
commit | 3ac37a93fa9217e576bebfd4ba3e80edaaeb2289 (patch) | |
tree | 5ac022d5c88ad6842a498ed57d9de4cacd01a01b /fs/signalfd.c | |
parent | 9627808d2d409279cea3fb334212d04a83ff6371 (diff) | |
download | linux-3ac37a93fa9217e576bebfd4ba3e80edaaeb2289.tar.gz linux-3ac37a93fa9217e576bebfd4ba3e80edaaeb2289.tar.bz2 linux-3ac37a93fa9217e576bebfd4ba3e80edaaeb2289.zip |
printk: lock/unlock console only for new logbuf entries
Prior to commit 5c2992ee7fd8a29 ("printk: remove console flushing special
cases for partial buffered lines") we would do console_cont_flush()
for each pr_cont() to print cont fragments, so console_unlock() would
actually print data:
pr_cont();
console_lock();
console_unlock()
console_cont_flush(); // print cont fragment
...
pr_cont();
console_lock();
console_unlock()
console_cont_flush(); // print cont fragment
We don't do console_cont_flush() anymore, so when we do pr_cont()
console_unlock() does nothing (unless we flushed the cont buffer):
pr_cont();
console_lock();
console_unlock(); // noop
...
pr_cont();
console_lock();
console_unlock(); // noop
...
pr_cont();
cont_flush();
console_lock();
console_unlock(); // print data
We also wakeup klogd purposelessly for pr_cont() output - un-flushed
cont buffer is not stored in log_buf; there is nothing to pull.
Thus we can console_lock()/console_unlock()/wake_up_klogd() only when
we know that we log_store()-ed a message and there is something to
print to the consoles/syslog.
Link: http://lkml.kernel.org/r/20181002023836.4487-3-sergey.senozhatsky@gmail.com
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Diffstat (limited to 'fs/signalfd.c')
0 files changed, 0 insertions, 0 deletions