diff options
| author | Jan Kara <jack@suse.cz> | 2024-01-09 11:06:57 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2024-01-23 19:21:10 +0100 |
| commit | 2ed0d3d4fee199869e9aef09bc86ceed9d79b978 (patch) | |
| tree | 3612b6f245c78baf70497a71201b3c310173e15e /fs/udf | |
| parent | f6766303c0f2ffbcc640ef2701984a81a274aff2 (diff) | |
| download | linux-2ed0d3d4fee199869e9aef09bc86ceed9d79b978.tar.gz linux-2ed0d3d4fee199869e9aef09bc86ceed9d79b978.tar.bz2 linux-2ed0d3d4fee199869e9aef09bc86ceed9d79b978.zip | |
udf: Avoid GFP_NOFS allocation in udf_symlink()
The GFP_NOFS allocation in udf_symlink() is called only under
inode->i_rwsem and UDF_I(inode)->i_data_sem. The first is safe wrt
reclaim, the second should be as well but allocating unde this lock is
actually unnecessary. Move the allocation from under i_data_sem and
change it to GFP_KERNEL.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf')
| -rw-r--r-- | fs/udf/namei.c | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 1f14a0621a91..1308109fd42d 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -566,7 +566,7 @@ out: static int udf_symlink(struct mnt_idmap *idmap, struct inode *dir, struct dentry *dentry, const char *symname) { - struct inode *inode = udf_new_inode(dir, S_IFLNK | 0777); + struct inode *inode; struct pathComponent *pc; const char *compstart; struct extent_position epos = {}; @@ -579,17 +579,20 @@ static int udf_symlink(struct mnt_idmap *idmap, struct inode *dir, struct udf_inode_info *iinfo; struct super_block *sb = dir->i_sb; - if (IS_ERR(inode)) - return PTR_ERR(inode); - - iinfo = UDF_I(inode); - down_write(&iinfo->i_data_sem); - name = kmalloc(UDF_NAME_LEN_CS0, GFP_NOFS); + name = kmalloc(UDF_NAME_LEN_CS0, GFP_KERNEL); if (!name) { err = -ENOMEM; - goto out_no_entry; + goto out; + } + + inode = udf_new_inode(dir, S_IFLNK | 0777); + if (IS_ERR(inode)) { + err = PTR_ERR(inode); + goto out; } + iinfo = UDF_I(inode); + down_write(&iinfo->i_data_sem); inode->i_data.a_ops = &udf_symlink_aops; inode->i_op = &udf_symlink_inode_operations; inode_nohighmem(inode); |