diff options
| author | Dave Chinner <dchinner@redhat.com> | 2022-11-29 09:09:17 +1100 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2022-11-29 09:09:17 +1100 |
| commit | 304a68b9c63bbfc1f6e159d68e8892fc54a06067 (patch) | |
| tree | b3e4a82479f6e67701679f2fd3b7b8702a81dbd3 /fs/xfs/xfs_aops.c | |
| parent | d7b64041164ca177170191d2ad775da074ab2926 (diff) | |
| download | linux-304a68b9c63bbfc1f6e159d68e8892fc54a06067.tar.gz linux-304a68b9c63bbfc1f6e159d68e8892fc54a06067.tar.bz2 linux-304a68b9c63bbfc1f6e159d68e8892fc54a06067.zip | |
xfs: use iomap_valid method to detect stale cached iomaps
Now that iomap supports a mechanism to validate cached iomaps for
buffered write operations, hook it up to the XFS buffered write ops
so that we can avoid data corruptions that result from stale cached
iomaps. See:
https://lore.kernel.org/linux-xfs/20220817093627.GZ3600936@dread.disaster.area/
or the ->iomap_valid() introduction commit for exact details of the
corruption vector.
The validity cookie we store in the iomap is based on the type of
iomap we return. It is expected that the iomap->flags we set in
xfs_bmbt_to_iomap() is not perturbed by the iomap core and are
returned to us in the iomap passed via the .iomap_valid() callback.
This ensures that the validity cookie is always checking the correct
inode fork sequence numbers to detect potential changes that affect
the extent cached by the iomap.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/xfs/xfs_aops.c')
| -rw-r--r-- | fs/xfs/xfs_aops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 6aadc5815068..a22d90af40c8 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -372,7 +372,7 @@ retry: isnullstartblock(imap.br_startblock)) goto allocate_blocks; - xfs_bmbt_to_iomap(ip, &wpc->iomap, &imap, 0, 0); + xfs_bmbt_to_iomap(ip, &wpc->iomap, &imap, 0, 0, XFS_WPC(wpc)->data_seq); trace_xfs_map_blocks_found(ip, offset, count, whichfork, &imap); return 0; allocate_blocks: |