summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk@kernel.org>2019-01-27 17:59:53 -0800
committerJaegeuk Kim <jaegeuk@kernel.org>2019-02-15 20:59:45 -0800
commit0e0667b625cf64243df83171bff61f9d350b9ca5 (patch)
treee21c5c3f05bc006dc337bf12f83689797d70ae62 /fs
parent11ac8ef8d8c575409dcce3bcf1dda3c9f8c7f5e9 (diff)
downloadlinux-0e0667b625cf64243df83171bff61f9d350b9ca5.tar.gz
linux-0e0667b625cf64243df83171bff61f9d350b9ca5.tar.bz2
linux-0e0667b625cf64243df83171bff61f9d350b9ca5.zip
f2fs: flush quota blocks after turnning it off
After quota_off, we'll get some dirty blocks. If put_super don't have a chance to flush them by checkpoint, it causes NULL pointer exception in end_io after iput(node_inode). (e.g., by checkpoint=disable) Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/f2fs/super.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 5e1f8573a17f..7694cb350734 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2026,6 +2026,12 @@ void f2fs_quota_off_umount(struct super_block *sb)
set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR);
}
}
+ /*
+ * In case of checkpoint=disable, we must flush quota blocks.
+ * This can cause NULL exception for node_inode in end_io, since
+ * put_super already dropped it.
+ */
+ sync_filesystem(sb);
}
static void f2fs_truncate_quota_inode_pages(struct super_block *sb)