diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2016-06-02 14:15:56 -0700 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2016-06-07 09:45:40 -0700 |
| commit | 1e7c48fa9a34556639328d50780d12a304e0bb6d (patch) | |
| tree | 9a974e4a957ecd15d9d87888e673fe0d6b864f6f /fs | |
| parent | 9a449e9c3b34ef3f7029bd966f98cbbfccd144e5 (diff) | |
| download | linux-1e7c48fa9a34556639328d50780d12a304e0bb6d.tar.gz linux-1e7c48fa9a34556639328d50780d12a304e0bb6d.tar.bz2 linux-1e7c48fa9a34556639328d50780d12a304e0bb6d.zip | |
f2fs: avoid data race between FI_DIRTY_INODE flag and update_inode
FI_DIRTY_INODE flag is not covered by inode page lock, so it can be unset
at any time like below.
Thread #1 Thread #2
- lock_page(ipage)
- update i_fields
- update i_size/i_blocks/and so on
- set FI_DIRTY_INODE
- reset FI_DIRTY_INODE
- set_page_dirty(ipage)
In this case, we can lose the latest i_field information.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/f2fs/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index fb3d9bd597e3..63c432673c71 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -231,6 +231,8 @@ int update_inode(struct inode *inode, struct page *node_page) { struct f2fs_inode *ri; + f2fs_inode_synced(inode); + f2fs_wait_on_page_writeback(node_page, NODE, true); ri = F2FS_INODE(node_page); @@ -265,7 +267,6 @@ int update_inode(struct inode *inode, struct page *node_page) __set_inode_rdev(inode, ri); set_cold_node(inode, node_page); - f2fs_inode_synced(inode); /* deleted inode */ if (inode->i_nlink == 0) |