diff options
| author | Eric Biggers <ebiggers@google.com> | 2021-01-12 11:02:52 -0800 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2021-01-13 17:26:53 +0100 |
| commit | 3aac630b5ce18b0a7e34cb35cdd99fcc508edc92 (patch) | |
| tree | c4da3550d112b52c211a5b8c8583c2af5dda6277 /fs | |
| parent | da0c4c60d8c7c8cc5266b0c5fe7bdf136e5e6415 (diff) | |
| download | linux-3aac630b5ce18b0a7e34cb35cdd99fcc508edc92.tar.gz linux-3aac630b5ce18b0a7e34cb35cdd99fcc508edc92.tar.bz2 linux-3aac630b5ce18b0a7e34cb35cdd99fcc508edc92.zip | |
gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync()
The I_DIRTY_TIME flag is primary used within the VFS, and there's no
reason for ->fsync() implementations to do anything with it. This is
because when !datasync, the VFS will expire dirty timestamps before
calling ->fsync(). (See vfs_fsync_range().) This turns I_DIRTY_TIME
into I_DIRTY_SYNC.
Therefore, change gfs2_fsync() to not check for I_DIRTY_TIME.
Link: https://lore.kernel.org/r/20210112190253.64307-11-ebiggers@kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/gfs2/file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index b39b339feddc..7fe2497755a3 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -749,7 +749,7 @@ static int gfs2_fsync(struct file *file, loff_t start, loff_t end, { struct address_space *mapping = file->f_mapping; struct inode *inode = mapping->host; - int sync_state = inode->i_state & I_DIRTY_ALL; + int sync_state = inode->i_state & I_DIRTY; struct gfs2_inode *ip = GFS2_I(inode); int ret = 0, ret1 = 0; @@ -762,7 +762,7 @@ static int gfs2_fsync(struct file *file, loff_t start, loff_t end, if (!gfs2_is_jdata(ip)) sync_state &= ~I_DIRTY_PAGES; if (datasync) - sync_state &= ~(I_DIRTY_SYNC | I_DIRTY_TIME); + sync_state &= ~I_DIRTY_SYNC; if (sync_state) { ret = sync_inode_metadata(inode, 1); |