summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2016-02-27 19:17:33 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2016-02-27 19:17:33 -0500
commitc80567c82ae4814a41287618e315a60ecf513be6 (patch)
tree34f4ef5e692f6667c9659332b56ebb09732a7534 /fs
parent0fcbf996d848d03573113d83f4e3fb3bcfa5ab5e (diff)
downloadlinux-c80567c82ae4814a41287618e315a60ecf513be6.tar.gz
linux-c80567c82ae4814a41287618e315a60ecf513be6.tar.bz2
linux-c80567c82ae4814a41287618e315a60ecf513be6.zip
do_last(): don't let a bogus return value from ->open() et.al. to confuse us
... into returning a positive to path_openat(), which would interpret that as "symlink had been encountered" and proceed to corrupt memory, etc. It can only happen due to a bug in some ->open() instance or in some LSM hook, etc., so we report any such event *and* make sure it doesn't trick us into further unpleasantness. Cc: stable@vger.kernel.org # v3.6+, at least Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/namei.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/namei.c b/fs/namei.c
index f624d132e01e..e30deefad8f8 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3273,6 +3273,10 @@ opened:
goto exit_fput;
}
out:
+ if (unlikely(error > 0)) {
+ WARN_ON(1);
+ error = -EINVAL;
+ }
if (got_write)
mnt_drop_write(nd->path.mnt);
path_put(&save_parent);