summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2020-11-17 07:59:16 -0700
committerJens Axboe <axboe@kernel.dk>2020-11-17 15:17:29 -0700
commitc993df5a688975bf9ce899706ca13d2bc8d6be25 (patch)
treea6d1a5aba707284fe2009ff3b49aff01fa036175 /fs
parent0abed7c69b956d135cb6d320c350b2adb213e7d8 (diff)
downloadlinux-c993df5a688975bf9ce899706ca13d2bc8d6be25.tar.gz
linux-c993df5a688975bf9ce899706ca13d2bc8d6be25.tar.bz2
linux-c993df5a688975bf9ce899706ca13d2bc8d6be25.zip
io_uring: don't double complete failed reissue request
Zorro reports that an xfstest test case is failing, and it turns out that for the reissue path we can potentially issue a double completion on the request for the failure path. There's an issue around the retry as well, but for now, at least just make sure that we handle the error path correctly. Cc: stable@vger.kernel.org Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because of resources") Reported-by: Zorro Lang <zlang@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs')
-rw-r--r--fs/io_uring.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c
index f05978a74ce1..b205c1df3f74 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2578,7 +2578,6 @@ static bool io_resubmit_prep(struct io_kiocb *req, int error)
}
end_req:
req_set_fail_links(req);
- io_req_complete(req, ret);
return false;
}
#endif