summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorChao Gao <chao.gao@intel.com>2022-11-30 23:09:26 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2022-12-29 15:48:32 -0500
commite4aa7f88af1a123863530af4a238ce64ec8fad5a (patch)
tree5c167c438350d01898a772cd24d49736b2dda32b /fs
parentaaf12a7b4323eb7d94677bcefc286ff6b772ed1c (diff)
downloadlinux-e4aa7f88af1a123863530af4a238ce64ec8fad5a.tar.gz
linux-e4aa7f88af1a123863530af4a238ce64ec8fad5a.tar.bz2
linux-e4aa7f88af1a123863530af4a238ce64ec8fad5a.zip
KVM: Disable CPU hotplug during hardware enabling/disabling
Disable CPU hotplug when enabling/disabling hardware to prevent the corner case where if the following sequence occurs: 1. A hotplugged CPU marks itself online in cpu_online_mask 2. The hotplugged CPU enables interrupt before invoking KVM's ONLINE callback 3 hardware_{en,dis}able_all() is invoked on another CPU the hotplugged CPU will be included in on_each_cpu() and thus get sent through hardware_{en,dis}able_nolock() before kvm_online_cpu() is called. start_secondary { ... set_cpu_online(smp_processor_id(), true); <- 1 ... local_irq_enable(); <- 2 ... cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); <- 3 } KVM currently fudges around this race by keeping track of which CPUs have done hardware enabling (see commit 1b6c016818a5 "KVM: Keep track of which cpus have virtualization enabled"), but that's an inefficient, convoluted, and hacky solution. Signed-off-by: Chao Gao <chao.gao@intel.com> [sean: split to separate patch, write changelog] Signed-off-by: Sean Christopherson <seanjc@google.com> Message-Id: <20221130230934.1014142-43-seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions