diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-10-19 11:19:13 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-22 19:27:14 -0700 |
| commit | 81fa7a69c2174ed8de314b9c231ef30a8718e5e1 (patch) | |
| tree | f6a64bb3d0f936c166444ad9555403771cfd0a10 /include/dt-bindings/phy/phy-ocelot-serdes.h | |
| parent | 29e270fc32192e7729057963ae7120663856c93e (diff) | |
| download | linux-81fa7a69c2174ed8de314b9c231ef30a8718e5e1.tar.gz linux-81fa7a69c2174ed8de314b9c231ef30a8718e5e1.tar.bz2 linux-81fa7a69c2174ed8de314b9c231ef30a8718e5e1.zip | |
dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1
SERDES_MAX is a valid value to index ctrl->phys in
drivers/phy/mscc/phy-ocelot-serdes.c. But, currently,
there is an out-of-bounds bug in the mentioned driver
when reading from ctrl->phys, because the size of
array ctrl->phys is SERDES_MAX.
Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1.
Notice that this is the first part of the solution to
the out-of-bounds bug mentioned above. Although this
change is not dependent on any other one.
Suggested-by: Quentin Schulz <quentin.schulz@bootlin.com>
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/dt-bindings/phy/phy-ocelot-serdes.h')
| -rw-r--r-- | include/dt-bindings/phy/phy-ocelot-serdes.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/dt-bindings/phy/phy-ocelot-serdes.h b/include/dt-bindings/phy/phy-ocelot-serdes.h index bd28f21206f6..fe70adaca68f 100644 --- a/include/dt-bindings/phy/phy-ocelot-serdes.h +++ b/include/dt-bindings/phy/phy-ocelot-serdes.h @@ -7,6 +7,6 @@ #define SERDES1G_MAX SERDES1G(5) #define SERDES6G(x) (SERDES1G_MAX + 1 + (x)) #define SERDES6G_MAX SERDES6G(2) -#define SERDES_MAX SERDES6G_MAX +#define SERDES_MAX (SERDES6G_MAX + 1) #endif |