diff options
author | Christoph Hellwig <hch@lst.de> | 2024-09-10 07:39:07 +0300 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2024-09-10 11:14:15 +0200 |
commit | 4bceb9ba05aca23652567fb5f899cc7fcb12c8d0 (patch) | |
tree | e77d1fd08e3a11076491ec552efd22bdbf27cac3 /include/linux/iomap.h | |
parent | 492f53758fad4fde3e9a98696780f8b53f87cdae (diff) | |
download | linux-4bceb9ba05aca23652567fb5f899cc7fcb12c8d0.tar.gz linux-4bceb9ba05aca23652567fb5f899cc7fcb12c8d0.tar.bz2 linux-4bceb9ba05aca23652567fb5f899cc7fcb12c8d0.zip |
iomap: remove the iomap_file_buffered_write_punch_delalloc return value
iomap_file_buffered_write_punch_delalloc can only return errors if either
the ->punch callback returned an error, or if someone changed the API of
mapping_seek_hole_data to return a negative error code that is not
-ENXIO.
As the only instance of ->punch never returns an error, an such an error
would be fatal anyway remove the entire error propagation and don't
return an error code from iomap_file_buffered_write_punch_delalloc.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240910043949.3481298-6-hch@lst.de
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'include/linux/iomap.h')
-rw-r--r-- | include/linux/iomap.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/iomap.h b/include/linux/iomap.h index ec2eab94f00a..4ad12a3c8bae 100644 --- a/include/linux/iomap.h +++ b/include/linux/iomap.h @@ -274,9 +274,9 @@ int iomap_truncate_page(struct inode *inode, loff_t pos, bool *did_zero, vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops); -typedef int (*iomap_punch_t)(struct inode *inode, loff_t offset, loff_t length, +typedef void (*iomap_punch_t)(struct inode *inode, loff_t offset, loff_t length, struct iomap *iomap); -int iomap_file_buffered_write_punch_delalloc(struct inode *inode, loff_t pos, +void iomap_file_buffered_write_punch_delalloc(struct inode *inode, loff_t pos, loff_t length, ssize_t written, unsigned flag, struct iomap *iomap, iomap_punch_t punch); |