diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2023-04-15 20:23:37 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2023-05-08 15:29:12 +0200 |
| commit | 939a116142012926e25de0ea6b7e2f8d86a5f1b6 (patch) | |
| tree | f0af17fbdceff2f7bc92e5b6b07a1cfec17c124d /include/linux/power | |
| parent | ff4c4a2a4437a6d03787c7aafb2617f20c3ef45f (diff) | |
| download | linux-939a116142012926e25de0ea6b7e2f8d86a5f1b6.tar.gz linux-939a116142012926e25de0ea6b7e2f8d86a5f1b6.tar.bz2 linux-939a116142012926e25de0ea6b7e2f8d86a5f1b6.zip | |
power: supply: bq27xxx: Ensure power_supply_changed() is called on current sign changes
On gauges where the current register is signed, there is no charging
flag in the flags register. So only checking flags will not result
in power_supply_changed() getting called when e.g. a charger is plugged
in and the current sign changes from negative (discharging) to
positive (charging).
This causes userspace's notion of the status to lag until userspace
does a poll.
And when a power_supply_leds.c LED trigger is used to indicate charging
status with a LED, this LED will lag until the capacity percentage
changes, which may take many minutes (because the LED trigger only is
updated on power_supply_changed() calls).
Fix this by calling bq27xxx_battery_current_and_status() on gauges with
a signed current register and checking if the status has changed.
Fixes: 297a533b3e62 ("bq27x00: Cache battery registers")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'include/linux/power')
| -rw-r--r-- | include/linux/power/bq27xxx_battery.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h index e3322dad9c85..7c8d65414a70 100644 --- a/include/linux/power/bq27xxx_battery.h +++ b/include/linux/power/bq27xxx_battery.h @@ -2,6 +2,8 @@ #ifndef __LINUX_BQ27X00_BATTERY_H__ #define __LINUX_BQ27X00_BATTERY_H__ +#include <linux/power_supply.h> + enum bq27xxx_chip { BQ27000 = 1, /* bq27000, bq27200 */ BQ27010, /* bq27010, bq27210 */ @@ -70,6 +72,7 @@ struct bq27xxx_device_info { int charge_design_full; bool removed; unsigned long last_update; + union power_supply_propval last_status; struct delayed_work work; struct power_supply *bat; struct list_head list; |