diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2016-11-14 18:48:07 -0600 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2016-11-22 11:49:49 -0600 |
| commit | 64b875f7ac8a5d60a4e191479299e931ee949b67 (patch) | |
| tree | 0c913f705ae947f5903ca0ff91ed633d1c2adc4a /include/linux/sched.h | |
| parent | bfedb589252c01fa505ac9f6f2a3d5d68d707ef4 (diff) | |
| download | linux-64b875f7ac8a5d60a4e191479299e931ee949b67.tar.gz linux-64b875f7ac8a5d60a4e191479299e931ee949b67.tar.bz2 linux-64b875f7ac8a5d60a4e191479299e931ee949b67.zip | |
ptrace: Capture the ptracer's creds not PT_PTRACE_CAP
When the flag PT_PTRACE_CAP was added the PTRACE_TRACEME path was
overlooked. This can result in incorrect behavior when an application
like strace traces an exec of a setuid executable.
Further PT_PTRACE_CAP does not have enough information for making good
security decisions as it does not report which user namespace the
capability is in. This has already allowed one mistake through
insufficient granulariy.
I found this issue when I was testing another corner case of exec and
discovered that I could not get strace to set PT_PTRACE_CAP even when
running strace as root with a full set of caps.
This change fixes the above issue with strace allowing stracing as
root a setuid executable without disabling setuid. More fundamentaly
this change allows what is allowable at all times, by using the correct
information in it's decision.
Cc: stable@vger.kernel.org
Fixes: 4214e42f96d4 ("v2.4.9.11 -> v2.4.9.12")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'include/linux/sched.h')
| -rw-r--r-- | include/linux/sched.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h index 348f51b0ec92..e9f693598e15 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1656,6 +1656,7 @@ struct task_struct { struct list_head cpu_timers[3]; /* process credentials */ + const struct cred __rcu *ptracer_cred; /* Tracer's credentials at attach */ const struct cred __rcu *real_cred; /* objective and real subjective task * credentials (COW) */ const struct cred __rcu *cred; /* effective (overridable) subjective task |