summaryrefslogtreecommitdiffstats
path: root/include/scsi/scsi_common.h
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2019-02-07 09:07:20 -0700
committerMartin K. Petersen <martin.petersen@oracle.com>2019-02-08 17:33:00 -0500
commit6f4e626fb0cc93d50b49b79c2ee33bd769ee57f0 (patch)
treebd3d49a1ad35778fd6f527668ce304b8c69ae936 /include/scsi/scsi_common.h
parent42fb055a57cab8d58db422efa4d867d3d8b39f8e (diff)
downloadlinux-6f4e626fb0cc93d50b49b79c2ee33bd769ee57f0.tar.gz
linux-6f4e626fb0cc93d50b49b79c2ee33bd769ee57f0.tar.bz2
linux-6f4e626fb0cc93d50b49b79c2ee33bd769ee57f0.zip
scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
Clang warns several times in the scsi subsystem (trimmed for brevity): drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to switch condition type (2147762695 to 18446744071562347015) [-Wswitch] case CCISS_GETBUSTYPES: ^ drivers/scsi/hpsa.c:6208:7: warning: overflow converting case value to switch condition type (2147762694 to 18446744071562347014) [-Wswitch] case CCISS_GETHEARTBEAT: ^ The root cause is that the _IOC macro can generate really large numbers, which don't fit into type 'int', which is used for the cmd parameter in the ioctls in scsi_host_template. My research into how GCC and Clang are handling this at a low level didn't prove fruitful. However, looking at the rest of the kernel tree, all ioctls use an 'unsigned int' for the cmd parameter, which will fit all of the _IOC values in the scsi/ata subsystems. Make that change because none of the ioctls expect a negative value for any command, it brings the ioctls inline with the reset of the kernel, and it removes ambiguity, which is never good when dealing with compilers. Link: https://github.com/ClangBuiltLinux/linux/issues/85 Link: https://github.com/ClangBuiltLinux/linux/issues/154 Link: https://github.com/ClangBuiltLinux/linux/issues/157 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Bradley Grove <bgrove@attotech.com> Acked-by: Don Brace <don.brace@microsemi.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Tested-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/scsi/scsi_common.h')
0 files changed, 0 insertions, 0 deletions