diff options
author | Aidan MacDonald <aidanmacdonald.0x0@gmail.com> | 2022-10-19 02:23:02 +0100 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2022-10-19 13:39:34 +0100 |
commit | 32def55d237e8507d4eb8442628fc2e59a899ea0 (patch) | |
tree | 99568687ec8ec2671ff236e0e5227a996144a08c /include/sound/simple_card_utils.h | |
parent | 75d8b1662ca5c20cf8365575222abaef18ff1f50 (diff) | |
download | linux-32def55d237e8507d4eb8442628fc2e59a899ea0.tar.gz linux-32def55d237e8507d4eb8442628fc2e59a899ea0.tar.bz2 linux-32def55d237e8507d4eb8442628fc2e59a899ea0.zip |
ASoC: simple-card: Fix up checks for HW param fixups
The "convert-xxx" properties only have an effect for DPCM DAI links.
A DAI link is only created as DPCM if the device tree requires it;
part of this involves checking for the use of "convert-xxx" properties.
When the convert-sample-format property was added, the checks got out
of sync. A DAI link that specified only convert-sample-format but did
not pass any of the other DPCM checks would not go into DPCM mode and
the convert-sample-format property would be silently ignored.
Fix this by adding a function to do the "convert-xxx" property checks,
instead of open-coding it in simple-card and audio-graph-card. And add
"convert-sample-format" to the check function so that DAI links using
it will be initialized correctly.
Fixes: 047a05366f4b ("ASoC: simple-card-utils: Fixup DAI sample format")
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Acked-by: Sameer Pujar <spujar@nvidia.com>
Link: https://lore.kernel.org/r/20221019012302.633830-1-aidanmacdonald.0x0@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'include/sound/simple_card_utils.h')
-rw-r--r-- | include/sound/simple_card_utils.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index a0b827f0c2f6..25e049f44178 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -177,6 +177,7 @@ void asoc_simple_convert_fixup(struct asoc_simple_data *data, struct snd_pcm_hw_params *params); void asoc_simple_parse_convert(struct device_node *np, char *prefix, struct asoc_simple_data *data); +bool asoc_simple_is_convert_required(const struct asoc_simple_data *data); int asoc_simple_parse_routing(struct snd_soc_card *card, char *prefix); |