summaryrefslogtreecommitdiffstats
path: root/include/trace/events/initcall.h
diff options
context:
space:
mode:
authorRishabh Bhatnagar <rishabhb@codeaurora.org>2018-04-25 16:42:35 -0700
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2018-04-26 15:02:46 -0400
commit0566e40ce7c493d39006cdd7edf17bfdc52eb2ac (patch)
tree959a3d2e000f22accb7e81b81e81702fbd7232d8 /include/trace/events/initcall.h
parent61f94203c9efcaf44a7435298697caf406476c79 (diff)
downloadlinux-0566e40ce7c493d39006cdd7edf17bfdc52eb2ac.tar.gz
linux-0566e40ce7c493d39006cdd7edf17bfdc52eb2ac.tar.bz2
linux-0566e40ce7c493d39006cdd7edf17bfdc52eb2ac.zip
tracing: initcall: Ordered comparison of function pointers
Using initcall_t in the __field macro generates the following warning with clang version 6.0: include/trace/events/initcall.h:34:3: warning: ordered comparison of function pointers ('initcall_t' (aka 'int (*)(void)') and 'initcall_t') __field macro expands to __field_ext macro which does is_signed_type check on the type argument. Since initcall_t is defined as a function pointer, using it as the type in the __field macro, leads to an ordered comparison of function pointer warning, inside the check. Using __field_struct macro avoids the issue. Link: http://lkml.kernel.org/r/1524699755-29388-1-git-send-email-rishabhb@codeaurora.org Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org> [ Added comment to why we are using field_struct() ] Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'include/trace/events/initcall.h')
-rw-r--r--include/trace/events/initcall.h14
1 files changed, 11 insertions, 3 deletions
diff --git a/include/trace/events/initcall.h b/include/trace/events/initcall.h
index 8d6cf10d27c9..eb903c3f195f 100644
--- a/include/trace/events/initcall.h
+++ b/include/trace/events/initcall.h
@@ -31,7 +31,11 @@ TRACE_EVENT(initcall_start,
TP_ARGS(func),
TP_STRUCT__entry(
- __field(initcall_t, func)
+ /*
+ * Use field_struct to avoid is_signed_type()
+ * comparison of a function pointer
+ */
+ __field_struct(initcall_t, func)
),
TP_fast_assign(
@@ -48,8 +52,12 @@ TRACE_EVENT(initcall_finish,
TP_ARGS(func, ret),
TP_STRUCT__entry(
- __field(initcall_t, func)
- __field(int, ret)
+ /*
+ * Use field_struct to avoid is_signed_type()
+ * comparison of a function pointer
+ */
+ __field_struct(initcall_t, func)
+ __field(int, ret)
),
TP_fast_assign(