diff options
author | Xiu Jianfeng <xiujianfeng@huawei.com> | 2024-10-12 07:22:46 +0000 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2024-10-14 13:39:25 -1000 |
commit | 3cc4e13bb1617f6a13e5e6882465984148743cf4 (patch) | |
tree | 9ad692dd6ca477c92cc1429b759f2c04f427498a /include/uapi/linux/tc_act/tc_gact.h | |
parent | 117932eea99b729ee5d12783601a4f7f5fd58a23 (diff) | |
download | linux-3cc4e13bb1617f6a13e5e6882465984148743cf4.tar.gz linux-3cc4e13bb1617f6a13e5e6882465984148743cf4.tar.bz2 linux-3cc4e13bb1617f6a13e5e6882465984148743cf4.zip |
cgroup: Fix potential overflow issue when checking max_depth
cgroup.max.depth is the maximum allowed descent depth below the current
cgroup. If the actual descent depth is equal or larger, an attempt to
create a new child cgroup will fail. However due to the cgroup->max_depth
is of int type and having the default value INT_MAX, the condition
'level > cgroup->max_depth' will never be satisfied, and it will cause
an overflow of the level after it reaches to INT_MAX.
Fix it by starting the level from 0 and using '>=' instead.
It's worth mentioning that this issue is unlikely to occur in reality,
as it's impossible to have a depth of INT_MAX hierarchy, but should be
be avoided logically.
Fixes: 1a926e0bbab8 ("cgroup: implement hierarchy limits")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'include/uapi/linux/tc_act/tc_gact.h')
0 files changed, 0 insertions, 0 deletions