diff options
author | Alexander Lobakin <alobakin@dlink.ru> | 2019-12-18 12:18:21 +0300 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2019-12-19 17:17:51 +0100 |
commit | 1148f9adbe71415836a18a36c1b4ece999ab0973 (patch) | |
tree | 2213331ef48ba5c35c92f2c1194f3d198fda984f /init/noinitramfs.c | |
parent | ca8d0fa7cfb8abc4f623d49df210e0b81b32f626 (diff) | |
download | linux-1148f9adbe71415836a18a36c1b4ece999ab0973.tar.gz linux-1148f9adbe71415836a18a36c1b4ece999ab0973.tar.bz2 linux-1148f9adbe71415836a18a36c1b4ece999ab0973.zip |
net, sysctl: Fix compiler warning when only cBPF is present
proc_dointvec_minmax_bpf_restricted() has been firstly introduced
in commit 2e4a30983b0f ("bpf: restrict access to core bpf sysctls")
under CONFIG_HAVE_EBPF_JIT. Then, this ifdef has been removed in
ede95a63b5e8 ("bpf: add bpf_jit_limit knob to restrict unpriv
allocations"), because a new sysctl, bpf_jit_limit, made use of it.
Finally, this parameter has become long instead of integer with
fdadd04931c2 ("bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K")
and thus, a new proc_dolongvec_minmax_bpf_restricted() has been
added.
With this last change, we got back to that
proc_dointvec_minmax_bpf_restricted() is used only under
CONFIG_HAVE_EBPF_JIT, but the corresponding ifdef has not been
brought back.
So, in configurations like CONFIG_BPF_JIT=y && CONFIG_HAVE_EBPF_JIT=n
since v4.20 we have:
CC net/core/sysctl_net_core.o
net/core/sysctl_net_core.c:292:1: warning: ‘proc_dointvec_minmax_bpf_restricted’ defined but not used [-Wunused-function]
292 | proc_dointvec_minmax_bpf_restricted(struct ctl_table *table, int write,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppress this by guarding it with CONFIG_HAVE_EBPF_JIT again.
Fixes: fdadd04931c2 ("bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K")
Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20191218091821.7080-1-alobakin@dlink.ru
Diffstat (limited to 'init/noinitramfs.c')
0 files changed, 0 insertions, 0 deletions