summaryrefslogtreecommitdiffstats
path: root/io_uring/io-wq.c
diff options
context:
space:
mode:
authorPavel Begunkov <asml.silence@gmail.com>2023-09-07 13:50:07 +0100
committerJens Axboe <axboe@kernel.dk>2023-09-07 09:02:27 -0600
commit45500dc4e01c167ee063f3dcc22f51ced5b2b1e9 (patch)
treefbb32c75506c587f3506ff75b5e706f3a9784995 /io_uring/io-wq.c
parent76d3ccecfa186af3120e206d62f03db1a94a535f (diff)
downloadlinux-45500dc4e01c167ee063f3dcc22f51ced5b2b1e9.tar.gz
linux-45500dc4e01c167ee063f3dcc22f51ced5b2b1e9.tar.bz2
linux-45500dc4e01c167ee063f3dcc22f51ced5b2b1e9.zip
io_uring: break out of iowq iopoll on teardown
io-wq will retry iopoll even when it failed with -EAGAIN. If that races with task exit, which sets TIF_NOTIFY_SIGNAL for all its workers, such workers might potentially infinitely spin retrying iopoll again and again and each time failing on some allocation / waiting / etc. Don't keep spinning if io-wq is dying. Fixes: 561fb04a6a225 ("io_uring: replace workqueue usage with io-wq") Cc: stable@vger.kernel.org Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring/io-wq.c')
-rw-r--r--io_uring/io-wq.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c
index 62f345587df5..1ecc8c748768 100644
--- a/io_uring/io-wq.c
+++ b/io_uring/io-wq.c
@@ -174,6 +174,16 @@ static void io_worker_ref_put(struct io_wq *wq)
complete(&wq->worker_done);
}
+bool io_wq_worker_stopped(void)
+{
+ struct io_worker *worker = current->worker_private;
+
+ if (WARN_ON_ONCE(!io_wq_current_is_worker()))
+ return true;
+
+ return test_bit(IO_WQ_BIT_EXIT, &worker->wq->state);
+}
+
static void io_worker_cancel_cb(struct io_worker *worker)
{
struct io_wq_acct *acct = io_wq_get_acct(worker);