diff options
| author | Xiubo Li <xiubli@redhat.com> | 2018-07-06 22:05:38 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-07 16:57:35 +0200 |
| commit | 543af5861f41af0a5d2432f6fb5976af50f9cee5 (patch) | |
| tree | adc110b102263f523ddf3848f9e57bedb64c0c66 /kernel/backtracetest.c | |
| parent | 9421e45f5ff3d558cf8b75a8cc0824530caf3453 (diff) | |
| download | linux-543af5861f41af0a5d2432f6fb5976af50f9cee5.tar.gz linux-543af5861f41af0a5d2432f6fb5976af50f9cee5.tar.bz2 linux-543af5861f41af0a5d2432f6fb5976af50f9cee5.zip | |
uio: change to use the mutex lock instead of the spin lock
We are hitting a regression with the following commit:
commit a93e7b331568227500186a465fee3c2cb5dffd1f
Author: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Date: Mon May 14 13:32:23 2018 +1200
uio: Prevent device destruction while fds are open
The problem is the addition of spin_lock_irqsave in uio_write. This
leads to hitting uio_write -> copy_from_user -> _copy_from_user ->
might_fault and the logs filling up with sleeping warnings.
I also noticed some uio drivers allocate memory, sleep, grab mutexes
from callouts like open() and release and uio is now doing
spin_lock_irqsave while calling them.
Reported-by: Mike Christie <mchristi@redhat.com>
CC: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/backtracetest.c')
0 files changed, 0 insertions, 0 deletions