diff options
| author | Sebastian Siewior <bigeasy@linutronix.de> | 2020-03-23 16:20:19 +0100 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-03-23 18:40:25 +0100 |
| commit | 8bf6c677ddb9c922423ea3bf494fe7c508bfbb8c (patch) | |
| tree | cd6f9bd2f9bc8054af511ef99185af5eea713e91 /kernel/sched/completion.c | |
| parent | d53f2b62fcb63f6547c10d8c62bca19e957b0eef (diff) | |
| download | linux-8bf6c677ddb9c922423ea3bf494fe7c508bfbb8c.tar.gz linux-8bf6c677ddb9c922423ea3bf494fe7c508bfbb8c.tar.bz2 linux-8bf6c677ddb9c922423ea3bf494fe7c508bfbb8c.zip | |
completion: Use lockdep_assert_RT_in_threaded_ctx() in complete_all()
The warning was intended to spot complete_all() users from hardirq
context on PREEMPT_RT. The warning as-is will also trigger in interrupt
handlers, which are threaded on PREEMPT_RT, which was not intended.
Use lockdep_assert_RT_in_threaded_ctx() which triggers in non-preemptive
context on PREEMPT_RT.
Fixes: a5c6234e1028 ("completion: Use simple wait queues")
Reported-by: kernel test robot <rong.a.chen@intel.com>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200323152019.4qjwluldohuh3by5@linutronix.de
Diffstat (limited to 'kernel/sched/completion.c')
| -rw-r--r-- | kernel/sched/completion.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index f15e96164ff1..a778554f9dad 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c @@ -58,7 +58,7 @@ void complete_all(struct completion *x) { unsigned long flags; - WARN_ON(irqs_disabled()); + lockdep_assert_RT_in_threaded_ctx(); raw_spin_lock_irqsave(&x->wait.lock, flags); x->done = UINT_MAX; |