diff options
| author | David Vernet <void@manifault.com> | 2024-02-05 22:39:19 -0600 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2024-02-28 15:19:23 +0100 |
| commit | 9dfbc26d27aaf0f5958c5972188f16fe977e5af5 (patch) | |
| tree | 7a1c26f43cca4969cdc9746f86ccd4b853283695 /kernel/sched | |
| parent | 23d04d8c6b8ec339057264659b7834027f3e6a63 (diff) | |
| download | linux-9dfbc26d27aaf0f5958c5972188f16fe977e5af5.tar.gz linux-9dfbc26d27aaf0f5958c5972188f16fe977e5af5.tar.bz2 linux-9dfbc26d27aaf0f5958c5972188f16fe977e5af5.zip | |
sched/fair: Remove unnecessary goto in update_sd_lb_stats()
In update_sd_lb_stats(), when we're iterating over the sched groups that
comprise a sched domain, we're skipping the call to
update_sd_pick_busiest() for the sched group that contains the local /
destination CPU. We use a goto to skip the call, but we could just as
easily check !local_group, as there's no other logic that we need to
skip with the goto. Let's remove the goto, and check for !local_group in
the if statement instead.
Signed-off-by: David Vernet <void@manifault.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20240206043921.850302-2-void@manifault.com
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/fair.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 352222d09c90..41dda5311770 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10580,16 +10580,11 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd update_sg_lb_stats(env, sds, sg, sgs, &sg_status); - if (local_group) - goto next_group; - - - if (update_sd_pick_busiest(env, sds, sg, sgs)) { + if (!local_group && update_sd_pick_busiest(env, sds, sg, sgs)) { sds->busiest = sg; sds->busiest_stat = *sgs; } -next_group: /* Now, start updating sd_lb_stats */ sds->total_load += sgs->group_load; sds->total_capacity += sgs->group_capacity; |