diff options
| author | Juhyung Park <qkrwngud825@gmail.com> | 2023-02-03 11:40:29 +0900 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-02-21 09:23:22 -0700 |
| commit | 9e0c7efa5ea231d85c0d41693a5115b3b971717c (patch) | |
| tree | b851624d2c0502249ad543a7ab1c88c3497c1579 /kernel/trace/blktrace.c | |
| parent | d88cbbb39b4db057feb1552de31f22c02a21b36f (diff) | |
| download | linux-9e0c7efa5ea231d85c0d41693a5115b3b971717c.tar.gz linux-9e0c7efa5ea231d85c0d41693a5115b3b971717c.tar.bz2 linux-9e0c7efa5ea231d85c0d41693a5115b3b971717c.zip | |
block: remove more NULL checks after bdev_get_queue()
bdev_get_queue() never returns NULL. Several commits [1][2] have been made
before to remove such superfluous checks, but some still remained.
For places where bdev_get_queue() is called solely for NULL checks, it is
removed entirely.
[1] commit ec9fd2a13d74 ("blk-lib: don't check bdev_get_queue() NULL check")
[2] commit fea127b36c93 ("block: remove superfluous check for request queue in bdev_is_zoned()")
Signed-off-by: Juhyung Park <qkrwngud825@gmail.com>
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>
Link: https://lore.kernel.org/r/20230203024029.48260-1-qkrwngud825@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'kernel/trace/blktrace.c')
| -rw-r--r-- | kernel/trace/blktrace.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 5743be559415..d5d94510afd3 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -729,14 +729,10 @@ EXPORT_SYMBOL_GPL(blk_trace_startstop); **/ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg) { - struct request_queue *q; + struct request_queue *q = bdev_get_queue(bdev); int ret, start = 0; char b[BDEVNAME_SIZE]; - q = bdev_get_queue(bdev); - if (!q) - return -ENXIO; - mutex_lock(&q->debugfs_mutex); switch (cmd) { |