diff options
| author | Dmitry Antipov <dmantipov@yandex.ru> | 2023-12-21 12:01:21 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2023-12-21 13:17:54 +0100 |
| commit | 1bfc466b13cf6652ba227c282c27a30ffede69a5 (patch) | |
| tree | c789ced6664ae08c5cce950ba77fb71765906de6 /kernel/watch_queue.c | |
| parent | 4cf8249dc907398f694d310b89b494c144a4d9ec (diff) | |
| download | linux-1bfc466b13cf6652ba227c282c27a30ffede69a5.tar.gz linux-1bfc466b13cf6652ba227c282c27a30ffede69a5.tar.bz2 linux-1bfc466b13cf6652ba227c282c27a30ffede69a5.zip | |
watch_queue: fix kcalloc() arguments order
When compiling with gcc version 14.0.0 20231220 (experimental)
and W=1, I've noticed the following warning:
kernel/watch_queue.c: In function 'watch_queue_set_size':
kernel/watch_queue.c:273:32: warning: 'kcalloc' sizes specified with 'sizeof'
in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
273 | pages = kcalloc(sizeof(struct page *), nr_pages, GFP_KERNEL);
| ^~~~~~
Since 'n' and 'size' arguments of 'kcalloc()' are multiplied to
calculate the final size, their actual order doesn't affect the
result and so this is not a bug. But it's still worth to fix it.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://lore.kernel.org/r/20231221090139.12579-1-dmantipov@yandex.ru
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'kernel/watch_queue.c')
| -rw-r--r-- | kernel/watch_queue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/watch_queue.c b/kernel/watch_queue.c index 778b4056700f..03b90d7d2175 100644 --- a/kernel/watch_queue.c +++ b/kernel/watch_queue.c @@ -270,7 +270,7 @@ long watch_queue_set_size(struct pipe_inode_info *pipe, unsigned int nr_notes) goto error; ret = -ENOMEM; - pages = kcalloc(sizeof(struct page *), nr_pages, GFP_KERNEL); + pages = kcalloc(nr_pages, sizeof(struct page *), GFP_KERNEL); if (!pages) goto error; |