summaryrefslogtreecommitdiffstats
path: root/kernel/workqueue.c
diff options
context:
space:
mode:
authorLai Jiangshan <laijs@cn.fujitsu.com>2014-05-22 16:44:07 +0800
committerTejun Heo <tj@kernel.org>2014-05-22 11:35:51 -0400
commit1037de36edae30f1ddc0a2532decd50f92ac4901 (patch)
tree3b79dc2d386d79ae339161a1e3cde1f0665d1ea0 /kernel/workqueue.c
parentcafebac153ae54fd0aba5d4ad28af995532c5375 (diff)
downloadlinux-1037de36edae30f1ddc0a2532decd50f92ac4901.tar.gz
linux-1037de36edae30f1ddc0a2532decd50f92ac4901.tar.bz2
linux-1037de36edae30f1ddc0a2532decd50f92ac4901.zip
workqueue: rename first_worker() to first_idle_worker()
first_worker() actually returns the first idle workers, the name first_idle_worker() which is self-commnet will be better. All the callers of first_worker() expect it returns an idle worker, the name first_idle_worker() with "idle" notation makes reviewers happier. Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
-rw-r--r--kernel/workqueue.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 6603923b7ede..dd107b83f45f 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -773,8 +773,8 @@ static bool too_many_workers(struct worker_pool *pool)
* Wake up functions.
*/
-/* Return the first worker. Safe with preemption disabled */
-static struct worker *first_worker(struct worker_pool *pool)
+/* Return the first idle worker. Safe with preemption disabled */
+static struct worker *first_idle_worker(struct worker_pool *pool)
{
if (unlikely(list_empty(&pool->idle_list)))
return NULL;
@@ -793,7 +793,7 @@ static struct worker *first_worker(struct worker_pool *pool)
*/
static void wake_up_worker(struct worker_pool *pool)
{
- struct worker *worker = first_worker(pool);
+ struct worker *worker = first_idle_worker(pool);
if (likely(worker))
wake_up_process(worker->task);
@@ -867,7 +867,7 @@ struct task_struct *wq_worker_sleeping(struct task_struct *task, int cpu)
*/
if (atomic_dec_and_test(&pool->nr_running) &&
!list_empty(&pool->worklist))
- to_wakeup = first_worker(pool);
+ to_wakeup = first_idle_worker(pool);
return to_wakeup ? to_wakeup->task : NULL;
}
@@ -3475,7 +3475,7 @@ static void put_unbound_pool(struct worker_pool *pool)
mutex_lock(&pool->manager_arb);
spin_lock_irq(&pool->lock);
- while ((worker = first_worker(pool)))
+ while ((worker = first_idle_worker(pool)))
destroy_worker(worker);
WARN_ON(pool->nr_workers || pool->nr_idle);
spin_unlock_irq(&pool->lock);