summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2017-09-07 17:03:52 +0200
committerIngo Molnar <mingo@kernel.org>2017-09-12 17:41:04 +0200
commit4ff9083b8a9a80bdf4ebbbec22cda4cbfb60f7aa (patch)
tree52a68f418d81153b7f70ee064d08cbfe051bb1d8 /kernel
parentedd8e41d2e3cbd6ebe13ead30eb1adc6f48cbb33 (diff)
downloadlinux-4ff9083b8a9a80bdf4ebbbec22cda4cbfb60f7aa.tar.gz
linux-4ff9083b8a9a80bdf4ebbbec22cda4cbfb60f7aa.tar.bz2
linux-4ff9083b8a9a80bdf4ebbbec22cda4cbfb60f7aa.zip
sched/core: WARN() when migrating to an offline CPU
Migrating tasks to offline CPUs is a pretty big fail, warn about it. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20170907150614.094206976@infradead.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/sched/core.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 136a76d80dbf..18a6966567da 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1173,6 +1173,10 @@ void set_task_cpu(struct task_struct *p, unsigned int new_cpu)
WARN_ON_ONCE(debug_locks && !(lockdep_is_held(&p->pi_lock) ||
lockdep_is_held(&task_rq(p)->lock)));
#endif
+ /*
+ * Clearly, migrating tasks to offline CPUs is a fairly daft thing.
+ */
+ WARN_ON_ONCE(!cpu_online(new_cpu));
#endif
trace_sched_migrate_task(p, new_cpu);