diff options
| author | Andy Lutomirski <luto@amacapital.net> | 2014-11-21 13:26:07 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-11-23 14:25:28 -0800 |
| commit | 82975bc6a6df743b9a01810fb32cb65d0ec5d60b (patch) | |
| tree | b5a5b092dcd8420d9f72bf66be2e6544a5622040 /kernel | |
| parent | 90e362f4a75d0911ca75e5cd95591a6cf1f169dc (diff) | |
| download | linux-82975bc6a6df743b9a01810fb32cb65d0ec5d60b.tar.gz linux-82975bc6a6df743b9a01810fb32cb65d0ec5d60b.tar.bz2 linux-82975bc6a6df743b9a01810fb32cb65d0ec5d60b.zip | |
uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME
x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set but
not on non-paranoid returns. I suspect that this is a mistake and that
the code only works because int3 is paranoid.
Setting _TIF_NOTIFY_RESUME in the uprobe code was probably a workaround
for the x86 bug. With that bug fixed, we can remove _TIF_NOTIFY_RESUME
from the uprobes code.
Reported-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/events/uprobes.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 1d0af8a2c646..ed8f2cde34c5 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1640,7 +1640,6 @@ bool uprobe_deny_signal(void) if (__fatal_signal_pending(t) || arch_uprobe_xol_was_trapped(t)) { utask->state = UTASK_SSTEP_TRAPPED; set_tsk_thread_flag(t, TIF_UPROBE); - set_tsk_thread_flag(t, TIF_NOTIFY_RESUME); } } |