diff options
| author | Ingo Molnar <mingo@kernel.org> | 2023-10-04 11:33:36 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2023-10-07 11:33:28 +0200 |
| commit | ea41bb514fe286bf50498b3c6d7f7a5dc2b6c5e0 (patch) | |
| tree | 40afc6baf98a8942fd83598b0cab733d7c946ac0 /kernel | |
| parent | 8db30574db25fa20cdcfa03e374edc3f8b8dc301 (diff) | |
| download | linux-ea41bb514fe286bf50498b3c6d7f7a5dc2b6c5e0.tar.gz linux-ea41bb514fe286bf50498b3c6d7f7a5dc2b6c5e0.tar.bz2 linux-ea41bb514fe286bf50498b3c6d7f7a5dc2b6c5e0.zip | |
sched/core: Update stale comment in try_to_wake_up()
The following commit:
9b3c4ab3045e ("sched,rcu: Rework try_invoke_on_locked_down_task()")
... renamed try_invoke_on_locked_down_task() to task_call_func(),
but forgot to update the comment in try_to_wake_up().
But it turns out that the smp_rmb() doesn't live in task_call_func()
either, it was moved to __task_needs_rq_lock() in:
91dabf33ae5d ("sched: Fix race in task_call_func()")
Fix that now.
Also fix the s/smb/smp typo while at it.
Reported-by: Zhang Qiao <zhangqiao22@huawei.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230731085759.11443-1-zhangqiao22@huawei.com
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 65e10ac34660..f5783cb16791 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4237,7 +4237,7 @@ int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) * Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in * __schedule(). See the comment for smp_mb__after_spinlock(). * - * A similar smb_rmb() lives in try_invoke_on_locked_down_task(). + * A similar smp_rmb() lives in __task_needs_rq_lock(). */ smp_rmb(); if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags)) |