diff options
| author | David Vernet <void@manifault.com> | 2023-03-25 16:31:45 -0500 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2023-03-25 16:56:22 -0700 |
| commit | fb2211a57c110b4ced3cb7f8570bd7246acf2d04 (patch) | |
| tree | 1d94a550acc6b2ee4a15129002a1a3bbbbea80b3 /kernel | |
| parent | 1431d0b584a673ea690c88a5f7e1aedd9caf0e84 (diff) | |
| download | linux-fb2211a57c110b4ced3cb7f8570bd7246acf2d04.tar.gz linux-fb2211a57c110b4ced3cb7f8570bd7246acf2d04.tar.bz2 linux-fb2211a57c110b4ced3cb7f8570bd7246acf2d04.zip | |
bpf: Remove now-unnecessary NULL checks for KF_RELEASE kfuncs
Now that we're not invoking kfunc destructors when the kptr in a map was
NULL, we no longer require NULL checks in many of our KF_RELEASE kfuncs.
This patch removes those NULL checks.
Signed-off-by: David Vernet <void@manifault.com>
Link: https://lore.kernel.org/r/20230325213144.486885-3-void@manifault.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/bpf/cpumask.c | 3 | ||||
| -rw-r--r-- | kernel/bpf/helpers.c | 6 |
2 files changed, 0 insertions, 9 deletions
diff --git a/kernel/bpf/cpumask.c b/kernel/bpf/cpumask.c index db9da2194c1a..e991af7dc13c 100644 --- a/kernel/bpf/cpumask.c +++ b/kernel/bpf/cpumask.c @@ -102,9 +102,6 @@ static void cpumask_free_cb(struct rcu_head *head) */ __bpf_kfunc void bpf_cpumask_release(struct bpf_cpumask *cpumask) { - if (!cpumask) - return; - if (refcount_dec_and_test(&cpumask->usage)) call_rcu(&cpumask->rcu, cpumask_free_cb); } diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index f753676ef652..8980f6859443 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -2089,9 +2089,6 @@ __bpf_kfunc struct task_struct *bpf_task_kptr_get(struct task_struct **pp) */ __bpf_kfunc void bpf_task_release(struct task_struct *p) { - if (!p) - return; - put_task_struct(p); } @@ -2148,9 +2145,6 @@ __bpf_kfunc struct cgroup *bpf_cgroup_kptr_get(struct cgroup **cgrpp) */ __bpf_kfunc void bpf_cgroup_release(struct cgroup *cgrp) { - if (!cgrp) - return; - cgroup_put(cgrp); } |