summaryrefslogtreecommitdiffstats
path: root/lib/crypto/mpi/mpiutil.c
diff options
context:
space:
mode:
authorRobert Richter <rrichter@amd.com>2025-03-20 12:22:22 +0100
committerIra Weiny <ira.weiny@intel.com>2025-03-20 16:54:27 -0500
commitef1d3455bbc1922f94a91ed58d3d7db440652959 (patch)
tree5c23bd85c15e4af18f0b75ee5a96d29a8b007346 /lib/crypto/mpi/mpiutil.c
parent2318fa87f808362994dee2773a7d3307c1cebabd (diff)
downloadlinux-ef1d3455bbc1922f94a91ed58d3d7db440652959.tar.gz
linux-ef1d3455bbc1922f94a91ed58d3d7db440652959.tar.bz2
linux-ef1d3455bbc1922f94a91ed58d3d7db440652959.zip
libnvdimm/labels: Fix divide error in nd_label_data_init()
If a faulty CXL memory device returns a broken zero LSA size in its memory device information (Identify Memory Device (Opcode 4000h), CXL spec. 3.1, 8.2.9.9.1.1), a divide error occurs in the libnvdimm driver: Oops: divide error: 0000 [#1] PREEMPT SMP NOPTI RIP: 0010:nd_label_data_init+0x10e/0x800 [libnvdimm] Code and flow: 1) CXL Command 4000h returns LSA size = 0 2) config_size is assigned to zero LSA size (CXL pmem driver): drivers/cxl/pmem.c: .config_size = mds->lsa_size, 3) max_xfer is set to zero (nvdimm driver): drivers/nvdimm/label.c: max_xfer = min_t(size_t, ndd->nsarea.max_xfer, config_size); 4) A subsequent DIV_ROUND_UP() causes a division by zero: drivers/nvdimm/label.c: /* Make our initial read size a multiple of max_xfer size */ drivers/nvdimm/label.c: read_size = min(DIV_ROUND_UP(read_size, max_xfer) * max_xfer, drivers/nvdimm/label.c- config_size); Fix this by checking the config size parameter by extending an existing check. Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> Link: https://patch.msgid.link/20250320112223.608320-1-rrichter@amd.com Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Diffstat (limited to 'lib/crypto/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions