diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2015-03-12 11:54:41 +1030 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2015-03-13 15:55:42 +1030 |
commit | 71e4b8bf0482fc7d70e9d4c10b13c207a285d58a (patch) | |
tree | 435db3fcf8c9e28fdc331b64fb0f4effb80b3138 /lib/parser.c | |
parent | 8051a2a518fcf3827a143470083ad6008697ff17 (diff) | |
download | linux-71e4b8bf0482fc7d70e9d4c10b13c207a285d58a.tar.gz linux-71e4b8bf0482fc7d70e9d4c10b13c207a285d58a.tar.bz2 linux-71e4b8bf0482fc7d70e9d4c10b13c207a285d58a.zip |
virtio_rpmsg: set DRIVER_OK before using device
virtio spec requires that all drivers set DRIVER_OK
before using devices. While rpmsg isn't yet
included in the virtio 1 spec, previous spec versions
also required this.
virtio rpmsg violates this rule: is calls kick
before setting DRIVER_OK.
The fix isn't trivial since simply calling virtio_device_ready earlier
would mean we might get an interrupt in parallel with adding buffers.
Instead, split kick out to prepare+notify calls. prepare before
virtio_device_ready - when we know we won't get interrupts. notify right
afterwards.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'lib/parser.c')
0 files changed, 0 insertions, 0 deletions