diff options
| author | John Hubbard <jhubbard@nvidia.com> | 2020-10-13 16:52:01 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2020-10-13 18:38:29 -0700 |
| commit | 146608bb75e6776af4cf42310f583d39311e5334 (patch) | |
| tree | a6c2a5d836f189b2e2138d7268ec29149fc89016 /mm/swap_state.c | |
| parent | 447f3e45c18a8f27018213bcb1b5a0076633f68a (diff) | |
| download | linux-146608bb75e6776af4cf42310f583d39311e5334.tar.gz linux-146608bb75e6776af4cf42310f583d39311e5334.tar.bz2 linux-146608bb75e6776af4cf42310f583d39311e5334.zip | |
mm/gup: protect unpin_user_pages() against npages==-ERRNO
As suggested by Dan Carpenter, fortify unpin_user_pages() just a bit,
against a typical caller mistake: check if the npages arg is really a
-ERRNO value, which would blow up the unpinning loop: WARN and return.
If this new WARN_ON() fires, then the system *might* be leaking pages (by
leaving them pinned), but probably not. More likely, gup/pup returned a
hard -ERRNO error to the caller, who erroneously passed it here.
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>
Link: https://lkml.kernel.org/r/20200917065706.409079-1-jhubbard@nvidia.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/swap_state.c')
0 files changed, 0 insertions, 0 deletions