summaryrefslogtreecommitdiffstats
path: root/net/6lowpan
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-04-03 08:34:16 +0300
committerMarcel Holtmann <marcel@holtmann.org>2019-04-23 19:09:58 +0200
commitf57c4bbf34439531adccd7d3a4ecc14f409c1399 (patch)
tree3a4e73e030d42615c6b76de7466ca5a621ca69c6 /net/6lowpan
parent5035726128cd2e3813ee44deedb9898509edb232 (diff)
downloadlinux-f57c4bbf34439531adccd7d3a4ecc14f409c1399.tar.gz
linux-f57c4bbf34439531adccd7d3a4ecc14f409c1399.tar.bz2
linux-f57c4bbf34439531adccd7d3a4ecc14f409c1399.zip
6lowpan: Off by one handling ->nexthdr
NEXTHDR_MAX is 255. What happens here is that we take a u8 value "hdr->nexthdr" from the network and then look it up in lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff then we read one element beyond the end of the array so the array needs to be one element larger. Fixes: 92aa7c65d295 ("6lowpan: add generic nhc layer interface") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> Acked-by: Alexander Aring <aring@mojatatu.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net/6lowpan')
-rw-r--r--net/6lowpan/nhc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/6lowpan/nhc.c b/net/6lowpan/nhc.c
index 4fa2fdda174d..9e56fb98f33c 100644
--- a/net/6lowpan/nhc.c
+++ b/net/6lowpan/nhc.c
@@ -18,7 +18,7 @@
#include "nhc.h"
static struct rb_root rb_root = RB_ROOT;
-static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX];
+static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX + 1];
static DEFINE_SPINLOCK(lowpan_nhc_lock);
static int lowpan_nhc_insert(struct lowpan_nhc *nhc)