summaryrefslogtreecommitdiffstats
path: root/net/appletalk
diff options
context:
space:
mode:
authorVincent Duvert <vincent.ldev@duvert.net>2020-08-02 07:06:51 +0200
committerDavid S. Miller <davem@davemloft.net>2020-08-03 15:48:32 -0700
commitd0f6ba2ef2c1c95069509e71402e7d6d43452512 (patch)
tree6519151b17e16f93d0ae81ce08a7ba962c046297 /net/appletalk
parent69462fe6a39048ec186f60178a3a6ea23ae16e0c (diff)
downloadlinux-d0f6ba2ef2c1c95069509e71402e7d6d43452512.tar.gz
linux-d0f6ba2ef2c1c95069509e71402e7d6d43452512.tar.bz2
linux-d0f6ba2ef2c1c95069509e71402e7d6d43452512.zip
appletalk: Fix atalk_proc_init() return path
Add a missing return statement to atalk_proc_init so it doesn't return -ENOMEM when successful. This allows the appletalk module to load properly. Fixes: e2bcd8b0ce6e ("appletalk: use remove_proc_subtree to simplify procfs code") Link: https://www.downtowndougbrown.com/2020/08/hacking-up-a-fix-for-the-broken-appletalk-kernel-module-in-linux-5-1-and-newer/ Reported-by: Christopher KOBAYASHI <chris@disavowed.jp> Reported-by: Doug Brown <doug@downtowndougbrown.com> Signed-off-by: Vincent Duvert <vincent.ldev@duvert.net> [lukas: add missing tags] Signed-off-by: Lukas Wunner <lukas@wunner.de> Cc: stable@vger.kernel.org # v5.1+ Cc: Yue Haibing <yuehaibing@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/appletalk')
-rw-r--r--net/appletalk/atalk_proc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca007cc..9c1241292d1d 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
sizeof(struct aarp_iter_state), NULL))
goto out;
+ return 0;
+
out:
remove_proc_subtree("atalk", init_net.proc_net);
return -ENOMEM;