diff options
author | Sven Eckelmann <sven@narfation.org> | 2016-01-16 10:29:56 +0100 |
---|---|---|
committer | Antonio Quartulli <a@unstable.cc> | 2016-02-10 23:24:06 +0800 |
commit | 7c12439115da77389733d9bf313f64eedaec3b73 (patch) | |
tree | 795d74a4209cd98798f0e4068ebe67a20e22655e /net/batman-adv/originator.h | |
parent | 161a3be9324eaed3ecd1879c994d58b16bbf4732 (diff) | |
download | linux-7c12439115da77389733d9bf313f64eedaec3b73.tar.gz linux-7c12439115da77389733d9bf313f64eedaec3b73.tar.bz2 linux-7c12439115da77389733d9bf313f64eedaec3b73.zip |
batman-adv: Convert batadv_orig_node to kref
batman-adv uses a self-written reference implementation which is just based
on atomic_t. This is less obvious when reading the code than kref and
therefore increases the change that the reference counting will be missed.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net/batman-adv/originator.h')
-rw-r--r-- | net/batman-adv/originator.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h index 745b4e4fcdc4..99507408f4cf 100644 --- a/net/batman-adv/originator.h +++ b/net/batman-adv/originator.h @@ -20,10 +20,10 @@ #include "main.h" -#include <linux/atomic.h> #include <linux/compiler.h> #include <linux/if_ether.h> #include <linux/jhash.h> +#include <linux/kref.h> #include <linux/rculist.h> #include <linux/rcupdate.h> #include <linux/stddef.h> @@ -115,7 +115,7 @@ batadv_orig_hash_find(struct batadv_priv *bat_priv, const void *data) if (!batadv_compare_eth(orig_node, data)) continue; - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!kref_get_unless_zero(&orig_node->refcount)) continue; orig_node_tmp = orig_node; |