summaryrefslogtreecommitdiffstats
path: root/net/dccp/feat.c
diff options
context:
space:
mode:
authorYueHaibing <yuehaibing@huawei.com>2019-04-01 09:35:54 +0800
committerDavid S. Miller <davem@davemloft.net>2019-04-01 18:15:10 -0700
commit1d3ff0950e2b40dc861b1739029649d03f591820 (patch)
tree7f51dc975414b684d55248e63621d135c298a770 /net/dccp/feat.c
parent09279e615c81ce55e04835970601ae286e3facbe (diff)
downloadlinux-1d3ff0950e2b40dc861b1739029649d03f591820.tar.gz
linux-1d3ff0950e2b40dc861b1739029649d03f591820.tar.bz2
linux-1d3ff0950e2b40dc861b1739029649d03f591820.zip
dccp: Fix memleak in __feat_register_sp
If dccp_feat_push_change fails, we forget free the mem which is alloced by kmemdup in dccp_feat_clone_sp_val. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values") Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp/feat.c')
-rw-r--r--net/dccp/feat.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/net/dccp/feat.c b/net/dccp/feat.c
index f227f002c73d..db87d9f58019 100644
--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
return -ENOMEM;
- return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
+ if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
+ kfree(fval.sp.vec);
+ return -ENOMEM;
+ }
+
+ return 0;
}
/**