diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2021-09-13 16:31:56 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-09-14 19:34:03 -0700 |
| commit | 339133f6c318612f9a4556c300753beda27abc01 (patch) | |
| tree | 4570bfbdf999dedcfca68eb40332440b9dd4021b /net/dsa/tag_rtl4_a.c | |
| parent | f2173257b92e9e29a3b87303331ee4a40dd5614f (diff) | |
| download | linux-339133f6c318612f9a4556c300753beda27abc01.tar.gz linux-339133f6c318612f9a4556c300753beda27abc01.tar.bz2 linux-339133f6c318612f9a4556c300753beda27abc01.zip | |
net: dsa: tag_rtl4_a: Drop bit 9 from egress frames
This drops the code setting bit 9 on egress frames on the
Realtek "type A" (RTL8366RB) frames.
This bit was set on ingress frames for unknown reason,
and was set on egress frames as the format of ingress
and egress frames was believed to be the same. As that
assumption turned out to be false, and since this bit
seems to have zero effect on the behaviour of the switch
let's drop this bit entirely.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210913143156.1264570-1-linus.walleij@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/dsa/tag_rtl4_a.c')
| -rw-r--r-- | net/dsa/tag_rtl4_a.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c index f920487ae145..6d928ee3ef7a 100644 --- a/net/dsa/tag_rtl4_a.c +++ b/net/dsa/tag_rtl4_a.c @@ -54,7 +54,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb, p = (__be16 *)tag; *p = htons(RTL4_A_ETHERTYPE); - out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT) | (2 << 8); + out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT); /* The lower bits indicate the port number */ out |= BIT(dp->index); |