summaryrefslogtreecommitdiffstats
path: root/net/ethtool
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2020-09-28 17:58:41 -0700
committerDavid S. Miller <davem@davemloft.net>2020-09-28 18:52:50 -0700
commit78b70155dc73280be2c7084a3be591161cdc6d0c (patch)
treeda5530e176fdd3836145fe29631edb1a9a5fc6c4 /net/ethtool
parent3ddf9b431b931544dc2f94e8f6a055ff501436fa (diff)
downloadlinux-78b70155dc73280be2c7084a3be591161cdc6d0c.tar.gz
linux-78b70155dc73280be2c7084a3be591161cdc6d0c.tar.bz2
linux-78b70155dc73280be2c7084a3be591161cdc6d0c.zip
ethtool: mark netlink family as __ro_after_init
Like all genl families ethtool_genl_family needs to not be a straight up constant, because it's modified/initialized by genl_register_family(). After init, however, it's only passed to genlmsg_put() & co. therefore we can mark it as __ro_after_init. Since genl_family structure contains function pointers mark this as a fix. Fixes: 2b4a8990b7df ("ethtool: introduce ethtool netlink interface") Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ethtool')
-rw-r--r--net/ethtool/netlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index 5c2072765be7..0c3f54baec4e 100644
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c
@@ -866,7 +866,7 @@ static const struct genl_multicast_group ethtool_nl_mcgrps[] = {
[ETHNL_MCGRP_MONITOR] = { .name = ETHTOOL_MCGRP_MONITOR_NAME },
};
-static struct genl_family ethtool_genl_family = {
+static struct genl_family ethtool_genl_family __ro_after_init = {
.name = ETHTOOL_GENL_NAME,
.version = ETHTOOL_GENL_VERSION,
.netnsok = true,