diff options
author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-12-26 22:27:52 +0900 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-12-30 07:25:52 +0000 |
commit | 936a192f974018b4f6040f6f77b1cc1e75bd8666 (patch) | |
tree | a69f32b36b71ddadb25fdffdba76d8ad380fc7f2 /net/ipv4/fou.c | |
parent | 40cab44b9089a41f71bbd0eff753eb91d5dafd68 (diff) | |
download | linux-936a192f974018b4f6040f6f77b1cc1e75bd8666.tar.gz linux-936a192f974018b4f6040f6f77b1cc1e75bd8666.tar.bz2 linux-936a192f974018b4f6040f6f77b1cc1e75bd8666.zip |
tcp: Add TIME_WAIT sockets in bhash2.
Jiri Slaby reported regression of bind() with a simple repro. [0]
The repro creates a TIME_WAIT socket and tries to bind() a new socket
with the same local address and port. Before commit 28044fc1d495 ("net:
Add a bhash2 table hashed by port and address"), the bind() failed with
-EADDRINUSE, but now it succeeds.
The cited commit should have put TIME_WAIT sockets into bhash2; otherwise,
inet_bhash2_conflict() misses TIME_WAIT sockets when validating bind()
requests if the address is not a wildcard one.
The straight option is to move sk_bind2_node from struct sock to struct
sock_common to add twsk to bhash2 as implemented as RFC. [1] However, the
binary layout change in the struct sock could affect performances moving
hot fields on different cachelines.
To avoid that, we add another TIME_WAIT list in inet_bind2_bucket and check
it while validating bind().
[0]: https://lore.kernel.org/netdev/6b971a4e-c7d8-411e-1f92-fda29b5b2fb9@kernel.org/
[1]: https://lore.kernel.org/netdev/20221221151258.25748-2-kuniyu@amazon.com/
Fixes: 28044fc1d495 ("net: Add a bhash2 table hashed by port and address")
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Acked-by: Joanne Koong <joannelkoong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fou.c')
0 files changed, 0 insertions, 0 deletions