diff options
| author | Zhipeng Lu <alexious@zju.edu.cn> | 2024-01-29 17:10:17 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-01-31 15:53:25 -0800 |
| commit | 5dee6d6923458e26966717f2a3eae7d09fc10bf6 (patch) | |
| tree | e49ea1341bb3d770af69ea056742488ba22f979a /net/ipv4/ip_output.c | |
| parent | e028243003ad6e1417cc8ac19af9ded672b9ec59 (diff) | |
| download | linux-5dee6d6923458e26966717f2a3eae7d09fc10bf6.tar.gz linux-5dee6d6923458e26966717f2a3eae7d09fc10bf6.tar.bz2 linux-5dee6d6923458e26966717f2a3eae7d09fc10bf6.zip | |
net: ipv4: fix a memleak in ip_setup_cork
When inetdev_valid_mtu fails, cork->opt should be freed if it is
allocated in ip_setup_cork. Otherwise there could be a memleak.
Fixes: 501a90c94510 ("inet: protect against too small mtu values.")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240129091017.2938835-1-alexious@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv4/ip_output.c')
| -rw-r--r-- | net/ipv4/ip_output.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index b06f678b03a1..41537d18eecf 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -1287,6 +1287,12 @@ static int ip_setup_cork(struct sock *sk, struct inet_cork *cork, if (unlikely(!rt)) return -EFAULT; + cork->fragsize = ip_sk_use_pmtu(sk) ? + dst_mtu(&rt->dst) : READ_ONCE(rt->dst.dev->mtu); + + if (!inetdev_valid_mtu(cork->fragsize)) + return -ENETUNREACH; + /* * setup for corking. */ @@ -1303,12 +1309,6 @@ static int ip_setup_cork(struct sock *sk, struct inet_cork *cork, cork->addr = ipc->addr; } - cork->fragsize = ip_sk_use_pmtu(sk) ? - dst_mtu(&rt->dst) : READ_ONCE(rt->dst.dev->mtu); - - if (!inetdev_valid_mtu(cork->fragsize)) - return -ENETUNREACH; - cork->gso_size = ipc->gso_size; cork->dst = &rt->dst; |