diff options
| author | Willem de Bruijn <willemb@google.com> | 2024-06-14 08:25:18 -0400 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-06-17 17:49:50 -0700 |
| commit | dd89a81d850fa9a65f67b4527c0e420d15bf836c (patch) | |
| tree | f3ffd9010d858c8cd8d35d244e7f4505d19b6a3f /net/ipv4 | |
| parent | 4314175af49668ab20c0d60d7d7657986e1d0c7c (diff) | |
| download | linux-dd89a81d850fa9a65f67b4527c0e420d15bf836c.tar.gz linux-dd89a81d850fa9a65f67b4527c0e420d15bf836c.tar.bz2 linux-dd89a81d850fa9a65f67b4527c0e420d15bf836c.zip | |
fou: remove warn in gue_gro_receive on unsupported protocol
Drop the WARN_ON_ONCE inn gue_gro_receive if the encapsulated type is
not known or does not have a GRO handler.
Such a packet is easily constructed. Syzbot generates them and sets
off this warning.
Remove the warning as it is expected and not actionable.
The warning was previously reduced from WARN_ON to WARN_ON_ONCE in
commit 270136613bf7 ("fou: Do WARN_ON_ONCE in gue_gro_receive for bad
proto callbacks").
Signed-off-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240614122552.1649044-1-willemdebruijn.kernel@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/fou_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c index a8494f796dca..0abbc413e0fe 100644 --- a/net/ipv4/fou_core.c +++ b/net/ipv4/fou_core.c @@ -433,7 +433,7 @@ next_proto: offloads = NAPI_GRO_CB(skb)->is_ipv6 ? inet6_offloads : inet_offloads; ops = rcu_dereference(offloads[proto]); - if (WARN_ON_ONCE(!ops || !ops->callbacks.gro_receive)) + if (!ops || !ops->callbacks.gro_receive) goto out; pp = call_gro_receive(ops->callbacks.gro_receive, head, skb); |