summaryrefslogtreecommitdiffstats
path: root/net/ipv6
diff options
context:
space:
mode:
authorYueHaibing <yuehaibing@huawei.com>2018-12-19 14:45:09 +0800
committerSteffen Klassert <steffen.klassert@secunet.com>2018-12-19 12:33:17 +0100
commitfa89a4593b927b3f59c3b69379f31d3b22272e4e (patch)
tree7569a640cb733f84f1849f1793cac61a5ab183df /net/ipv6
parentcc4acb1b6a86563ef5b6dc7c35d99f66d7b82557 (diff)
downloadlinux-fa89a4593b927b3f59c3b69379f31d3b22272e4e.tar.gz
linux-fa89a4593b927b3f59c3b69379f31d3b22272e4e.tar.bz2
linux-fa89a4593b927b3f59c3b69379f31d3b22272e4e.zip
xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi
gcc warn this: net/ipv6/xfrm6_tunnel.c:143 __xfrm6_tunnel_alloc_spi() warn: always true condition '(spi <= 4294967295) => (0-u32max <= u32max)' 'spi' is u32, which always not greater than XFRM6_TUNNEL_SPI_MAX because of wrap around. So the second forloop will never reach. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/ipv6')
-rw-r--r--net/ipv6/xfrm6_tunnel.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c
index 4a46df8441c9..f5b4febeaa25 100644
--- a/net/ipv6/xfrm6_tunnel.c
+++ b/net/ipv6/xfrm6_tunnel.c
@@ -144,6 +144,9 @@ static u32 __xfrm6_tunnel_alloc_spi(struct net *net, xfrm_address_t *saddr)
index = __xfrm6_tunnel_spi_check(net, spi);
if (index >= 0)
goto alloc_spi;
+
+ if (spi == XFRM6_TUNNEL_SPI_MAX)
+ break;
}
for (spi = XFRM6_TUNNEL_SPI_MIN; spi < xfrm6_tn->spi; spi++) {
index = __xfrm6_tunnel_spi_check(net, spi);