diff options
| author | Guillaume Nault <g.nault@alphalink.fr> | 2018-07-25 14:53:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-26 14:06:34 -0700 |
| commit | 2b139e6b1ec86e1d3646039965dd79ad05d8dca4 (patch) | |
| tree | 8118769260d6bd3c5d27472c4cd4ff4ae3e579b9 /net/l2tp/l2tp_ip.c | |
| parent | 63135ee0a6e5f5a5ad1345e48099e62d3d617a81 (diff) | |
| download | linux-2b139e6b1ec86e1d3646039965dd79ad05d8dca4.tar.gz linux-2b139e6b1ec86e1d3646039965dd79ad05d8dca4.tar.bz2 linux-2b139e6b1ec86e1d3646039965dd79ad05d8dca4.zip | |
l2tp: remove ->recv_payload_hook
The tunnel reception hook is only used by l2tp_ppp for skipping PPP
framing bytes. This is a session specific operation, but once a PPP
session sets ->recv_payload_hook on its tunnel, all frames received by
the tunnel will enter pppol2tp_recv_payload_hook(), including those
targeted at Ethernet sessions (an L2TPv3 tunnel can multiplex PPP and
Ethernet sessions).
So this mechanism is wrong, and uselessly complex. Let's just move this
functionality to the pppol2tp rx handler and drop ->recv_payload_hook.
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp/l2tp_ip.c')
| -rw-r--r-- | net/l2tp/l2tp_ip.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_ip.c b/net/l2tp/l2tp_ip.c index a9c05b2bc1b0..0bc39cc20a3f 100644 --- a/net/l2tp/l2tp_ip.c +++ b/net/l2tp/l2tp_ip.c @@ -165,7 +165,7 @@ static int l2tp_ip_recv(struct sk_buff *skb) print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, ptr, length); } - l2tp_recv_common(session, skb, ptr, optr, 0, skb->len, tunnel->recv_payload_hook); + l2tp_recv_common(session, skb, ptr, optr, 0, skb->len); l2tp_session_dec_refcount(session); return 0; |